search

govfresh / govpress

The WordPress theme for government
https://wordpress.org/themes/govpress/
GNU General Public License v2.0
135 stars 50 forks source link

Sidebar Always To The Right #72

Closed foolhandy closed 9 years ago

foolhandy commented 9 years ago

Hello,

Love the theme and am implementing it as a child theme here: http://www.stgilesgreatmaplestead.uk/

I'd love the full sidebar to always be on the right, but there doesn't seem to be any regularity about the Template page setting - sometimes the Full Page/Home Page settings put the sidebar on the right, sometimes on the left. Is there a way of setting the 'Default Template' to be a single right-sidebar for ALL pages?

Thanks!

devinsays commented 9 years ago

Can you send me an example where it shows up on the left?

foolhandy commented 9 years ago

Here you go: http://www.stgilesgreatmaplestead.uk/curriculum/

And some pages like this: http://www.stgilesgreatmaplestead.uk/parents/ with child pages have a different style of sidebar which just feature the child pages. If I then click on one of those child pages the sidebar is on the right: http://www.stgilesgreatmaplestead.uk/parents/friends-of-st-giles/

On Wed, Nov 5, 2014 at 8:03 PM, Devin Price notifications@github.com wrote:

Can you send me an example where it shows up on the left?

Reply to this email directly or view it on GitHub https://github.com/govfresh/govpress/issues/72#issuecomment-61871791.

foolhandy commented 9 years ago

Another example: http://www.stgilesgreatmaplestead.uk/school-history/ Set to 'Page Default' the sidebar is on the left and only shows the child page (150th Celebrations) Set to 'Full Page' there is no sidebar (obviously!) Set to 'Home Page' the sidebar is on the left and full of the widgets I set up on the widgets page.

Of the Parent pages only 'Home', 'News' (the blog page), & 'Contact' have the sidebar on the right, every other Parent page has the limited sidebar on the left. Child pages have the full sidebar on the right. All pages are set to 'Page Default'.

I'd like a full sidebar to the right on every page. Is this possible?

devinsays commented 9 years ago

Thanks @foolhandy. This is a feature @lukefretwell and I discussed in depth when creating the theme: https://github.com/govfresh/govpress/issues/24. @lukefretwell feel free to comment on this ticket if you have thoughts.

It looks like I forgot to build out a page template (right sidebar), that would allow you to override the default behavior. I'll go ahead and do that and push out a new version. That will allow you to override the sidebar position on those specific pages. Would that solution work for you?

foolhandy commented 9 years ago

That would be perfect! I can see occasions when having the simple left subnav sidebar would work brilliantly but the option to override it would be brilliant. I shall look forward to the update. Thank you!

lukefretwell commented 9 years ago

@devinsays @foolhandy Great idea and think a lot of others would like that.

devinsays commented 9 years ago

I think sidebars we should standardize the sidebar. If someone wants to do something special for page parents, they can use widget visibility plugin from JetPack to specify that. I'm pulling out the custom functionality in this commit: 88a4e04

Next one will add layouts.

devinsays commented 9 years ago

106b3c4c8f5c2fe48257b0ff86007dc2d2aadc3e adds layout options.

Use the Customizer to set the layout for the entire site. Each page and post also now have their own layout options.

The page template for "Full Width" needs to be removed, but I'll have to write an update routine for that.

@lukefretwell would you mind testing this a bit?

foolhandy commented 9 years ago

Does the removal of the "Full Width" option mean you would always have to have a sidebar? Perhaps it would be useful to keep it as an option, for image/video content, embedded documents etc.?

Karl On 17 Dec 2014 03:04, "Devin Price" notifications@github.com wrote:

106b3c4 https://github.com/govfresh/govpress/commit/106b3c4c8f5c2fe48257b0ff86007dc2d2aadc3e adds layout options.

Use the Customizer to set the layout for the entire site. Each page and post also now have their own layout options.

The page template for "Full Width" needs to be removed, but I'll have to write an update routine for that.

@lukefretwell https://github.com/lukefretwell would you mind testing this a bit?

Reply to this email directly or view it on GitHub https://github.com/govfresh/govpress/issues/72#issuecomment-67271053.

devinsays commented 9 years ago

There are three layout options available:

So the page template is no longer needed.

lukefretwell commented 9 years ago

Tested and looks great!

ksvenee commented 9 years ago

Hi there, first of all thank you for this awesome theme! :)

When I switch to "2 Columns: Sidebar / Content" and visit the Site on a mobile Device (Nexus7 2012 & iPhone 4), there is on the left site 1/3 white space. My Site: http://goo.gl/D2TlJY The same thing is under http://www.stgilesgreatmaplestead.uk/curriculum/ .

A "Sidebar left and right" Layout would be interesting for me.

devinsays commented 9 years ago

@ksvenee Thanks for helping us test! Appreciate the bug report.

I just pushed a fix for that: 479d882