govhackaustralia / hackerspace3

Competition Management System for the GovHack Hackathon
GNU Affero General Public License v3.0
21 stars 12 forks source link

Implement Action Text #99

Open cassar opened 4 years ago

cassar commented 4 years ago

Background

Will be great greatly improve experience of writing articles on the Hackerspace.

Tasks

waiholiu commented 4 years ago

@cassar

anyone looking at this one? If not, happy to take a look at it.

cassar commented 4 years ago

@waiholiu , Yeah go for it!

Looking forward to having this in.

Do you have an AWS account to test photo drag and drop?

Ok if not, we can test on staging.

waiholiu commented 4 years ago

cool, well i haven't played around with AWS at all - but i do have experience with azure and firebase.

Is that just a matter of overriding the values in storage.yml with those of my own s3 bucket? I believe there's a 12 month trial so I'll sign up for that if it's free.

cassar commented 4 years ago

Nah, there is a couple of env variables that you set, check the bottom of the readme in the repo.

waiholiu commented 4 years ago

hey @cassar

Some questions. So I've tried to install ActionText by running rails action_text:install as per the instructions on the site and appears like it requires a db schema change cause it produces a migration file.

Anyway, the migration file wants to create two new tables active_storage_attachment and active_storage_blobs. But these tables already exist in the schema.

I don't know enough about rails to know what's going on - I just know that running db:migrate causes a duplicate table error (rightly, because it's trying to create tables that already exist).

So is this a clash with another library? Why do these tables already exist?

cassar commented 4 years ago

Hey @waiholiu ,

It's trying to reinstall Active Storage which is what we use to upload assets like images and PDFs.

Since we already have these tables, deleting the migration should allow you to proceed with installation.

waiholiu commented 4 years ago

@cassar - so I've checked in the work I've done at this branch https://github.com/govhackaustralia/hackerspace3/tree/actiontext

It wasn't trival to install and it didn't "just work" according to the instructions.

I did the following changes on top of the change

I've made the changes to the edit event page to demonstrate but it doesn't look right.

Below is a screenshot of the trix-editor at the top where it's on it's own, and then later on inside a form inside the "field" class. So yeah we would need to do a bit of work styling it.

image

In addition, I can't seem to add a link, add an image etc. to the trix editor - I'm not sure why that is.

I haven't tried the Save functionality yet, although from the specified instructions, it doesn't seem like it would be that hard.