package rename freezes vim

aitva commented 4 years ago

What version of Vim/Gvim are you using?

Vim/Gvim version

$ vim --version
VIM - Vi IMproved 8.1 (2018 May 18, compiled Sep  3 2019 15:39:10)
Included patches: 1-1967
Compiled by aitva
Huge version without GUI.  Features included (+) or not (-):
+acl               -farsi             -mouse_sysmouse    -tag_any_white
+arabic            +file_in_path      +mouse_urxvt       -tcl
+autocmd           +find_in_path      +mouse_xterm       +termguicolors
+autochdir         +float             +multi_byte        +terminal
-autoservername    +folding           +multi_lang        +terminfo
-balloon_eval      -footer            -mzscheme          +termresponse
+balloon_eval_term +fork()            +netbeans_intg     +textobjects
-browse            -gettext           +num64             +textprop
++builtin_terms    -hangul_input      +packages          +timers
+byte_offset       +iconv             +path_extra        +title
+channel           +insert_expand     -perl              -toolbar
+cindent           +job               +persistent_undo   +user_commands
-clientserver      +jumplist          +postscript        +vartabs
-clipboard         +keymap            +printer           +vertsplit
+cmdline_compl     +lambda            +profile           +virtualedit
+cmdline_hist      +langmap           -python            +visual
+cmdline_info      +libcall           -python3           +visualextra
+comments          +linebreak         +quickfix          +viminfo
+conceal           +lispindent        +reltime           +vreplace
+cryptv            +listcmds          +rightleft         +wildignore
+cscope            +localmap          -ruby              +wildmenu
+cursorbind        -lua               +scrollbind        +windows
+cursorshape       +menu              +signs             +writebackup
+dialog_con        +mksession         +smartindent       -X11
+diff              +modify_fname      -sound             -xfontset
+digraphs          +mouse             +spell             -xim
-dnd               -mouseshape        +startuptime       -xpm
-ebcdic            +mouse_dec         +statusline        -xsmp
+emacs_tags        -mouse_gpm         -sun_workshop      -xterm_clipboard
+eval              -mouse_jsbterm     +syntax            -xterm_save
+ex_extra          +mouse_netterm     +tag_binary
+extra_search      +mouse_sgr         -tag_old_static
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
  fall-back for $VIM: "/usr/local/share/vim"
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H     -O2 -fno-strength-reduce -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc   -L/usr/local/lib -Wl,--as-needed -o vim        -lm -ltinfo -lnsl  -ldl

What version of Go are you using (`go version`)?

$ go version
go version go1.13.1 linux/arm64

What operating system and processor architecture are you using (`go env`)?

go env Output

$ go env
GO111MODULE="on"
GOARCH="arm64"
GOBIN=""
GOCACHE="/home/aitva/.cache/go-build"
GOENV="/home/aitva/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/aitva/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_arm64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/aitva/dev/edited/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build228054873=/tmp/go-build -gno-record-gcc-switches"

What version/commit of `govim` are you using?

commit 35c32a559f17b415543c62f4494c02de795a0c08

What is the output of `:messages` in Vim?

I cannot access :messages, Vim was frozen and I had to kill it.

Do the Vim channel, `govim` or `gopls` log files show anything interesting?

I had a look but found nothing fancy.

How did you install `govim`?

vim-plug

What did you do?

I was manually renaming a small package with a few types. Once I hit :w Vim completely froze.

I reproduced the bug in the govim repo:

cd cmd/govim/internal/golang_org_x_tools
mv lsp lsp-test
vim -p lsp-test/code_action.go
change package lsp to package lsp-test
save :w

As a note, Vim returns a segmentation fault once killed:

Vim: Caught deadly signal TERM
Segmentation fault

What did you expect to see?

Vim saving the file as usual.

What did you see instead?

A frozen / unresponsive Vim, I had to kill it from another prompt.

myitcv commented 4 years ago

@aitva thanks for the report and for providing a repro. Apologies for the delay in replying to this.

I just tried the repro against govim 35c32a5 and Vim v8.1.1967 but was unable to repro this.

Are you able to consistently repro this? If so, it might be worth us raising as a Vim issue

myitcv commented 4 years ago

Closing as we've received no further reports of this. We can always re-open in case there is something specific with govim usage that causes this.

govim / govim