DFC | 416 | Implement Language Toggle In Common Express

govuk-one-login / ipv-cri-common-express

Common frontend components for Credential Issuers

MIT License

2 stars 0 forks source link

DFC | 416 | Implement Language Toggle In Common Express #344

Closed SophiaDWokoma closed 7 months ago

SophiaDWokoma commented 8 months ago

Proposed changes

What changed

Middleware functions added for retrieving and setting a new environment variable (LANGUAGE_TOGGLE_ENABLED).
The language toggle imported and added to base files.

Why did it change

To enable the activation of the language toggle component in repos that use Common Express

Issue tracking

DFC-416

Checklists

Environment variables or secrets

[x] No environment variables or secrets were added or changed

Other considerations

[ ] Update README with any new instructions or tasks

Screenshots: Desktop:

Mobile

Joanneyoung01 commented 8 months ago

Hey Sophia, looks good so far, i left a comment about the ordering and moving out the < div > containers, so it matches mobile....

Also please can I ask if it's possible to attach print screens from dev testing? Just want to double check that when used on the pod repos that they match the designs!

SophiaDWokoma commented 8 months ago

@Joanneyoung01 @di-fabs when I removed the div containers, the SonarCloud scan failed but I can't understand why, can anyone help me understand what the issue is please?

Joanneyoung01 commented 7 months ago

Is this all sorted now @SophiaDWokoma - looks like it's passing all the tests!

sonarcloud[bot] commented 7 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud