govuk-one-login / ipv-cri-common-express

Common frontend components for Credential Issuers
MIT License
2 stars 0 forks source link

Remove inconsistent landmark #401

Open wilsond-gds opened 2 weeks ago

wilsond-gds commented 2 weeks ago

Issue

The common express code adds a role=complimentary to the phase banner code to pass automated accessibility testing.

However, this affects the rendering of the page in assitive technologies and could be confusing for users. The Design System team have documented the background to their decision to not fix the automated warning.

Solution

To keep the service consistent and only inform assitive technology users of the useful areas of the page, remove the role attribute from the nunjucks call on line 32 of base-page.njk.

Tagging @fewtrees-pa for visibility as requested