govuk-one-login / service-header

A header for services using GOV.UK One Login
https://govuk-one-login.github.io/service-header/
6 stars 4 forks source link

Aria-labels for navigation landmarks contain redundant descriptions #47

Open wilsond-gds opened 1 month ago

wilsond-gds commented 1 month ago

This issue was initially described by Anika Henke.

When the example header’s <nav> landmarks:

<nav aria-label="GOV.UK One Login menu" class="one-login-header__nav" data-open-class="one-login-header__nav--open" id="one-login-header__nav">

<nav aria-label="Name of example service menu">

are read out by a screen reader, they are announced as ‘GOV.UK One Login menu, navigation’ and ‘Name of example service menu, navigation’.

As the words ‘menu’ and ‘navigation’ could be considered to communicate the same information, removing ‘menu’ from the labels would provide a shorter announcement while still informing the user of the purpose of these landmarks.