govuk-one-login / tech-docs

Documentation for integrating with GOV.UK One Login
https://docs.sign-in.service.gov.uk/
MIT License
8 stars 3 forks source link

ATO-732: Add login_required error code description #230

Open BenjaminWCO opened 4 months ago

BenjaminWCO commented 4 months ago

Why

We're adding support for a new "login_required" re-authentication error code. See:

What

Technical writer support

Yes, please provide feedback on any corrections or improvements.

How to review

Changelog

Confirm

sabrinaharris commented 4 months ago

Thanks! Not ready for merging as this needs tech writer support. I'll check who can pick this up 👍

PippaClarkGDS commented 4 months ago

hi @BenjaminWCO let me know when the changes have been made and I'll do another review

BenjaminWCO commented 4 months ago

hi @BenjaminWCO let me know when the changes have been made and I'll do another review

Thanks @PippaClarkGDS , taking a look now.

BenjaminWCO commented 4 months ago

Hi @PippaClarkGDS, I've made those changes. Thanks for the help. Just made one small tweak to your recommendations regarding the email as you suggested might be the case. Let me know if you have any other thoughts.

PippaClarkGDS commented 4 months ago

Nice @BenjaminWCO - @sabrinaharris will be able to add her review now

BenjaminWCO commented 4 months ago

Thanks @ethanmills, @PippaClarkGDS . I'll wait for confirmation from @sabrinaharris and the changes to be in production before I merge this.

BenjaminWCO commented 3 months ago

Hi, @sabrinaharris, fixed the change log conflict.