Refactoring base code to use googlemaps Go API

goware / geotools

Geo-location lookup library / service built on Google Maps API

MIT License

2 stars 1 forks source link

Closed xiam closed 8 years ago

xiam commented 8 years ago

Refactoring base code to use https://github.com/googlemaps/google-maps-services-go instead of raw HTTP requests.

pkieltyka commented 8 years ago

looks good aside from minor comments

xiam commented 8 years ago

@pkieltyka thanks for reviewing, I renamed defaultClient to defaultMapsClient.

xiam commented 8 years ago

Please don't merge just yet, I'll probably keep adding new stuff while working on https://github.com/pressly/api/issues/1355

xiam commented 8 years ago

Ready for review!

VojtechVitek commented 8 years ago

LGTM, only minor syntax/sugar suggestions.

xiam commented 8 years ago

I added more code to support mock responses.

pkieltyka commented 8 years ago

LGTM for merge + deploy :)