goware / geotools

Geo-location lookup library / service built on Google Maps API
MIT License
2 stars 1 forks source link

rename "_testdata" to "testdata" #6

Closed pkieltyka closed 8 years ago

pkieltyka commented 8 years ago

Go build tools treat the folder "testdata" as special and won't try to build its files

pkieltyka commented 8 years ago

btw, what do the contents of the various gob files in testdata/ hold? perhaps these should be just regular "code" in a gmaps_test.go file that make up a bunch of fixture/mock vars

xiam commented 8 years ago

There should be a way to do this, I'd love to get rid of the gob binary as well.

pkieltyka commented 8 years ago

lets iterate on it.. try a few approaches. as well, search google for articles on mocking in Golang.. a lot of recommendations are to use interfaces

xiam commented 8 years ago

Closing because this is not valid anymore.

pkieltyka commented 8 years ago

however, please delete _testdata before closing this ticket.. so we dont forget

VojtechVitek commented 8 years ago

Done in #12