goweiwen / Allium

A custom launcher for the Miyoo Mini and Miyoo Mini Plus handheld devices
GNU General Public License v3.0
134 stars 14 forks source link

GBAOffset filter out of date, causes issues with some Onion overlays #78

Closed Pobega closed 1 month ago

Pobega commented 2 months ago

From what I can tell the GBAOffset filter needs to be one pixel higher, and the Perfect_GBA overlay has been updated to be one pixel shorter (https://github.com/OnionUI/Onion/pull/1537).

After putting all of these files from Onion onto my Allium install I now have a working GBA overlay. I'm not sure what method you use for updating these from Onion, but if it's not automatic I can throw up a PR bringing in these specific files -- just let me know.

Pobega commented 2 months ago

I realize now that I actually added the Perfect_GBA overlay myself from Onion, but used the included GBAOffset.filt filter.

Should I open a PR to add this overlay/filter to Allium?

goweiwen commented 2 months ago

I don't have any workflow for updating the overlays. Please go ahead with the PR if you have time, it would help a lot.