search

gowong / material-sheet-fab

Android library that provides the floating action button to sheet transition from Google's Material Design.
MIT License
1.58k stars 255 forks source link

Readme Fab sample #30

Closed apex39 closed 7 years ago

apex39 commented 8 years ago

Sample class of Fab shown in README should contain all three defaulf constructors:

public Fab(Context context) {
        super(context);
    }

public Fab(Context context, AttributeSet attrs) {
        super(context, attrs);
    }

public Fab(Context context, AttributeSet attrs, int defStyleAttr) {
        super(context, attrs, defStyleAttr);
    }

IDE yells that class has no default constructor but a programmer who has no idea how widgets are implemented can run into XML inflating error when implementing only one constructor.

gowong commented 7 years ago

Putting this in the readme is unnecessary since it's obvious the constructors are needed and the IDE helps autocomplete them.