gowravshekar / bootstrap-webpack

bootstrap package for webpack
MIT License
136 stars 22 forks source link

Advice on peerDependencies vs dependencies #4

Closed justin808 closed 9 years ago

justin808 commented 9 years ago

I'm maintaining similar project: https://github.com/justin808/bootstrap-sass-loader

Wondering if other loaders should be peerDependencies or dependencies in package.json:

https://github.com/gowravshekar/bootstrap-webpack/blob/master/package.json#L18

  "dependencies": {
    "css-loader": "~0.6.3",
    "less-loader": "~0.6.2",
    "style-loader": "~0.6.0"
  },
  "peerDependencies": {
    "bootstrap": ">=3.0.2"
  }
bebraw commented 9 years ago

I think peer dependencies are the way to go. I've used that for React components. The problem with direct dependencies is that you can easily end up with multiple different versions of the same dependency in your bundle. Peer dependencies avoid that and it's up to user to pick the right version to use. It's a good idea to keep peer dependencies pretty loose (up to next major version or something).

gowravshekar commented 9 years ago

Added loaders in peerDependencies.