search

gowravshekar / font-awesome-webpack

font-awesome package for webpack
MIT License
192 stars 49 forks source link

Webpack 4 breaks font-awesome-webpack... #41

Open jarecsni opened 6 years ago

jarecsni commented 6 years ago

Due to this module depending on an old version of less-loader.

Does anyone know of a fork supporting webpack 4 as this project seems to be defunct?

jarecsni commented 6 years ago

I forked this project and updated the dependencies, which solved the build problem. Not sure if it makes sense to raise a PR here.

komali2 commented 6 years ago

why did i become a web developer

why

thescientist13 commented 6 years ago

@jarecsni , thanks for making that fork!

I tested it out using

$ yarn add font-awesome-webpack@https://github.com/jarecsni/font-awesome-webpack#440af2a2efe7ba1779d039556f04538e57bad4bb --dev

and all is working for me. I think you should make a PR for the dependency upgrade, IMO. 👍

JoelParke commented 6 years ago

I too have tested it out as above. And it is working fine. So If you can make a PR, that would be great!

JoelParke commented 6 years ago

@jarecsni I think a pull request would be good.

nstrelow commented 6 years ago

@jarecsni Please make a PR, this would be very helpful to people still using this.

Are there alternatives?

eregnier commented 6 years ago

I forked @jarecsni fork to do the PR : https://github.com/gowravshekar/font-awesome-webpack/pull/42 wait & see.

thescientist13 commented 6 years ago

thanks @eregnier !

bparticle commented 6 years ago

Any pointers on how to obtain the patch or fork to make font-awesome work with webpack 4 right now? I'm not yet quite up to speed with the flow of things around here I'm afraid :(

eregnier commented 6 years ago

@bparticle you can install @jarecsni fork with up to date version using something like

npm i git@github.com:jarecsni/font-awesome-webpack.git

until I hope his fork is merged to the upstream repository.

bparticle commented 6 years ago

@eregnier Thanks for your answer. I'm getting this error, even though the repository does contain a package.json file: Could not install from "github.com:jarecsni/font-awesome-webpack.git" as it does not contain a package.json file.

eregnier commented 6 years ago

indeed, there is an issue with npm and git URI.

instead, try :

npm i https://github.com/jarecsni/font-awesome-webpack.git

I tried it this time and it works for me.

tapz commented 5 years ago

My fork:

https://www.npmjs.com/package/font-awesome-webpack-4

"font-awesome-webpack-4": "1.0.0",

thescientist13 commented 5 years ago

thank you @tapz 🙏

Will give it a try and let you know!

JoelParke commented 5 years ago

Awesome @tapz -- I am not using this directly and have removed my fork!

JamesTheHacker commented 5 years ago

A SASS version would be beautiful.