search

goxr3plus / XR3Player

🎧 🎼 The MOST ADVANCED JavaFX Media Player
https://xr3player.netlify.com/
GNU Lesser General Public License v3.0
725 stars 176 forks source link

VM arguments ad add-exports #43

Closed HelgeStenstrom closed 5 years ago

HelgeStenstrom commented 5 years ago

The VM arguments, as written in README.md are probably slightly wrong. I don't think there should be an equal sign after add-exports or add-opens. See for example: https://javaworklife.wordpress.com/2019/05/20/java11-intellij-running-tests-with-add-exports-in-intellij/

So it should be: --add-exports javafx.controls/com.sun.javafx.scene.control.behavior=com.jfoenix --add-exports javafx.controls/com.sun.javafx.scene.control=com.jfoenix --add-exports javafx.base/com.sun.javafx.binding=com.jfoenix --add-exports javafx.graphics/com.sun.javafx.stage=com.jfoenix --add-exports javafx.base/com.sun.javafx.event=com.jfoenix --add-opens java.base/java.lang.reflect=ALL-UNNAMED --add-exports javafx.graphics/com.sun.javafx.scene=org.controlsfx.controls, --add-exports javafx.graphics/com.sun.javafx.scene.traversal=org.controlsfx.controls

goxr3plus commented 5 years ago

Thank you , have you tested that it works like that ?

HelgeStenstrom commented 5 years ago

No

tors 11 juli 2019 kl. 14:54 skrev GOXR3PLUS STUDIO <notifications@github.com

:

Thank you , have you tested that it works like that ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/goxr3plus/XR3Player/issues/43?email_source=notifications&email_token=AABJLY5KGAEMNKRPS6IXHELP64UPHA5CNFSM4H7DUYB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZWTGTA#issuecomment-510473036, or mute the thread https://github.com/notifications/unsubscribe-auth/AABJLY2AAI34AMNFZ75KFZTP64UPHANCNFSM4H7DUYBQ .

goxr3plus commented 5 years ago

Okay i tested they work , so the final is this : 

--add-exports
javafx.controls/com.sun.javafx.scene.control.behavior=com.jfoenix
--add-exports
javafx.controls/com.sun.javafx.scene.control=com.jfoenix
--add-exports
javafx.base/com.sun.javafx.binding=com.jfoenix
--add-exports
javafx.graphics/com.sun.javafx.stage=com.jfoenix
--add-exports
javafx.base/com.sun.javafx.event=com.jfoenix
--add-exports
javafx.graphics/com.sun.javafx.scene=org.controlsfx.controls,
--add-exports
javafx.graphics/com.sun.javafx.scene.traversal=org.controlsfx.controls
HelgeStenstrom commented 5 years ago

Do you really have newline after --add-exports?

goxr3plus commented 5 years ago

Do you really have newline after --add-exports? IntelliJ putted it automatically for some reason ...

goxr3plus commented 5 years ago

Should we close this ?

HelgeStenstrom commented 5 years ago

The newlines are removed now, right? If so, close this.