search

goxr3plus / XR3Player

🎧 🎼 The MOST ADVANCED JavaFX Media Player
https://xr3player.netlify.com/
GNU Lesser General Public License v3.0
724 stars 176 forks source link

What is the difference between xPlayer 0, 1 and 2? #44

Closed HelgeStenstrom closed 5 years ago

HelgeStenstrom commented 5 years ago

https://github.com/goxr3plus/XR3Player/blob/c4a3299f9dd0e2f7c1e44bc8d1a8714a8d99ab98/src/main/java/com/goxr3plus/xr3player/controllers/djmode/DJMode.java#L46-L48

They are different. Or rather; they are subsequently initialized in different ways. Can these xPlayers be given more clarifying names?

goxr3plus commented 5 years ago

The xPlayer0 is the one in the Main Window , The XPlayer1 and xPlayer2 are the 2 players on the djmode.

goxr3plus commented 5 years ago

I must refactor the code , i have to admit it's very confusing in some parts .

goxr3plus commented 5 years ago

XPlayer 0 image1

XPlayer1 and XPlayer 2 https://user-images.githubusercontent.com/20374208/48313813-34fdc180-e5ca-11e8-9da7-c6148dc0cbe5.png

goxr3plus commented 5 years ago

I hope this was clear to you so i am closing this issue :)