search

goxr3plus / XR3Player

🎧 🎼 The MOST ADVANCED JavaFX Media Player
https://xr3player.netlify.com/
GNU Lesser General Public License v3.0
725 stars 176 forks source link

Tell me about how you use your own separate libraries in this project #70

Open HelgeStenstrom opened 4 years ago

HelgeStenstrom commented 4 years ago

I'm curious to how you work with changes in java-stream-player that you do for the needs of XR3Player.

Do you use java-stream-player as a compiled jar-file when you run XR3Player? If so, do you download it from the same repository as I get it from, or is it just local on your machine? If it's on your local machine, can you have the same pom.xml file as I have, i.e., the same as exists here on GitHub? Or do you tweak the pom file to look in a local repository? What is the turn-around time from a small change in java-stream-player until you can test it in XR3Player?

goxr3plus commented 4 years ago

Actually i have it locally and building it locally , and Maven has a special dependency syntax to use your local jars , as far as you can see if you run mvn clean install on java-stream-player it biulds automatically a new jar :) .

One more thing you can do is create a new tag every x changes for example 9.1.2 , 9.1.3 and everytime rebuild with JitPack and test it.

Locally is faster i thing.

Here is the syntax you need for local jar with Maven . https://stackoverflow.com/questions/4955635/how-to-add-local-jar-files-to-a-maven-project

Please have a look so you find the best solution , i had it on the pom file , i removed it how i was doing it , so i could give you the code directly :)

java-stream-player is a maven java repository , i am using JitPack , so everytime i make changes and a new release of java-stream-player i can just add it as a dependency using JitPack , look here https://jitpack.io/private#goxr3plus/java-stream-player

I have not tested java-stream-player since 5 months because it became more complex and it will take time testing compatibility with XR3Player.

@HelgeStenstrom

HelgeStenstrom commented 4 years ago

So if I understand it correctly, when you do changes in a library that XR3Player depends on, for the sake of XR3Player, your pom.xml file is somewhat different than the one published here on GitHub. Do you use the solution by Alireza Fattahi, which has the most votes on stackoverflow? It's said to be deprecated, but still work. Or do you use some variant of it?

goxr3plus commented 4 years ago

I found it :) => https://github.com/goxr3plus/XR3Player/blob/40ceb19633e7a74f9b28fdce7b129dd316cecee8/pom.xml#L339-L351

----------- GENERALLY TALKING YOU MAY NOT NEED --------------------------------------- Useful here .

Have a look on this link also here .