goxr3plus / XR3Player

🎧 🎼 The MOST ADVANCED JavaFX Media Player
https://xr3player.netlify.com/
GNU Lesser General Public License v3.0
725 stars 176 forks source link

There are many dependencies in the idea software that need to be re-joined #81

Open mingtianshi opened 2 years ago

goxr3plus commented 2 years ago

What do you mean my friend :)

I have given all the instructions on the read me :) . Idea software is just what i use , you can do it in Eclipse too .

mingtianshi commented 2 years ago
        <!-- CHROMIUM BROWSER -->
        <dependency>
            <groupId>com.teamdev.jxbrowser</groupId>
            <artifactId>jxbrowser-win64</artifactId>
            <version>6.23.1</version>
        </dependency>

I'm sorry, but this place doesn't seem to have this dependency pack, but there's a version 7.12.2

The maven version I use is 3.6.3

goxr3plus commented 2 years ago

Well they took down that dependency from Maven central? That's very strange. Well the version 7.12.2 is paid. Mmmmm it looks that I have too remove completely the browser from the App. In the meantime I have another branch With JXBrowser 7 can you have a look on that if it works for you :)? I will have a look on XR3Player tommorow to see about the JxBrowser :)

goxr3plus commented 2 years ago

It was so good with Version 6 until they decided to not provide anymore open-source license for version 7... Whatever I will just remove the browser no big problem there :)

HelgeStenstrom commented 2 years ago

I'm not a user of XR3Player, but I'm interested in how it's build, as use it as inspiration. I haven't opened the project in my IDE (IntelliJ) for a long time. Now it seems to be broken, and the problem is related to jxbrowser. The first problem is https://github.com/goxr3plus/XR3Player/blob/3bdda1a9b4c2e80eb648b4fc055c41587b96d4e6/src/main/java/module-info.java#L47 which is marked in red (Module not found: jxbrowser). I kind understand a part of it. Like you say above, there is no version 6.23.1 in Maven Central, only 7.12.2. See https://mvnrepository.com/artifact/com.teamdev.jxbrowser/jxbrowser. But I have version 6.23.1 in my local ~/.m2/repository, so there should be no need for Maven to go out on the net to look for this dependency. I'm running on Mac; I don't know if that matters.

If I made XR3Player for my own needs, I would remove the browser. But it's not my project.

goxr3plus commented 2 years ago

I agree with you guyz I need to remove it from XR3Player it needs some work it was working perfectly before they release version 7 and it broke everything because of the license.

I will put effort on it to remove it completely soon.

goxr3plus commented 2 years ago

I am just too busy recently with my Playstore apps and work. Give me some time.

goxr3plus commented 2 years ago

Big news 💯 🥇 ( USE JAVA 18 )

I completely removed JxBrowser from XR3Player , also i have updated all the dependencies and now we are running on JAVA 18 .

I will probably remove also dropbox support .

I also need to fix an error when the user tries to create a playlist it says database connection closed for some reason which i haven't searched yet .

Get the latest commits and enjoy @HelgeStenstrom @mingtianshi

image

Yo remember to include on VM options these

2019-08-01_18-04-22

In order to run the project you should add the following VM Options ( easy using IntelliJ , Eclipse or Netbeans ) :

--add-exports javafx.controls/com.sun.javafx.scene.control.behavior=com.jfoenix
--add-exports javafx.controls/com.sun.javafx.scene.control=com.jfoenix
--add-exports javafx.base/com.sun.javafx.binding=com.jfoenix
--add-exports javafx.graphics/com.sun.javafx.stage=com.jfoenix
--add-exports javafx.base/com.sun.javafx.event=com.jfoenix
--add-exports javafx.graphics/com.sun.javafx.scene=org.controlsfx.controls,
--add-exports javafx.graphics/com.sun.javafx.scene.traversal=org.controlsfx.controls