goxr3plus / java-stream-player

🌌Java Advanced Audio Controller Library (WAV, AU, AIFF, MP3, OGG VORBIS, FLAC, MONKEY's AUDIO and SPEEX audio formats )
GNU General Public License v3.0
147 stars 33 forks source link

Improve unit testing #59

Closed HelgeStenstrom closed 4 years ago

HelgeStenstrom commented 4 years ago

Description

Improved and more complete unit tests.

StreamPlayerMethodsTest still contains tests that don't pass. The tested methods are candidates for removal from StreamPlayer.

All tests in StreamPlayerMethodsTest must be reviewed: Do they actually verify anything that need to be verified? Or are they too coupled with the current implementation?

StreamPlayerFutureImprovementTest contains tests that currently fail. Failures are caused by behavior in StreamPlayer which I think is wrong or bad. But I may have misinterpreted the intended behavior.

This PR doesn't add any dependencies.

What kind of change does this PR introduce? (check at least one)

Does this PR introduce a breaking change? (check one)

Has This Been Tested?

Checklist:

goxr3plus commented 4 years ago

Thank you, i have reviewed your code and merging.

I have seen your other issues i will reply to one by one, it's that i am very busy with the company i am working and i didn't had much time, thank you ♥

HelgeStenstrom commented 4 years ago

Although unit tests are harmless in themselves, this PR needs reviewing.

goxr3plus commented 4 years ago

I had a good look from my mobile on all the 3 files changed, it's just i don't have an option from the app to accept the review code, i can directly merge :)