goxr3plus / java-stream-player

🌌Java Advanced Audio Controller Library (WAV, AU, AIFF, MP3, OGG VORBIS, FLAC, MONKEY's AUDIO and SPEEX audio formats )

GNU General Public License v3.0

147 stars 33 forks source link

Remove cyclic dependency by moving creation method to factory class #77

Open HelgeStenstrom opened 2 years ago

HelgeStenstrom commented 2 years ago

Description

A static creation method is moved from an interface to a new factory class, in order to break a dependency cycle.

What kind of change does this PR introduce? (check at least one)

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Code style update
[ x] Refactor
[ ] Build-related changes
[ ] This change requires a documentation update
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[ x] No

Has This Been Tested?

[ x] Yes
[ ] No

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] Any dependent changes have been merged and published in downstream modules