gozoinks / homebridge-camera-ffmpeg-ufv

UniFi Video plugin for Homebridge
https://www.npmjs.com/package/homebridge-camera-ffmpeg-ufv
Other
76 stars 20 forks source link

iOS 13 Ready? #41

Closed roycepope closed 3 years ago

roycepope commented 4 years ago

Anybody know if this plugin is good to go for iOS 13? I really like this plugin and it would be a real shame for it to be broken we updating to iOS 13. Has anybody tried the iOS 13 beta with this?

jnanes commented 4 years ago

Plugin works but push notifications with screenshots are broken completely. On Sep 5, 2019, 8:00 PM -0400, Royce Pope notifications@github.com, wrote:

Anybody know if this plugin is good to go for iOS 13? I really like this plugin and it would be a real shame for it to be broken we updating to iOS 13. Has anybody tried the iOS 13 beta with this? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

JJJ commented 4 years ago

Audio/video works great in iOS 13. I don’t use notifications, so I’m not sure about them either way.

Here’s a screen shot from the Home app on my phone running the latest beta: F895658E-54BF-4C37-966A-32944CF625A3

roycepope commented 4 years ago

Thanks guys, it sounds like existing functionality is going to be intact. Will open future issues if they arise when iOS 13 releases.

ryanschmidt commented 4 years ago

I can confirm that push notifications are busted in iOS 13.

jmbwell commented 4 years ago

I get thumbnails sometimes, I don’t get them sometimes. I need to investigate. Open to input.

jnanes commented 4 years ago

Worst. Any idea if the screenshot notifications are able to be fixed? On Sep 22, 2019, 8:12 PM -0400, John Burwell notifications@github.com, wrote:

Reopened #41. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

roycepope commented 4 years ago

Should we wait for iOS 13.1 to be released by the end of the month? I hear this is supposed to fix a lot of things for HomeKit.

ryanschmidt commented 4 years ago

I do think 13.1 is supposed to have some fixes. I guess we won't know if that will affect this or not. I assume if they changed how the notification images work others will need to update their apps as well.

ryanschmidt commented 4 years ago

Just noticed that I am getting image previews to MacOS HomeKit but the same notification doesn't send a preview to iOS or WatchOS. For that reason, I don't think this is something that needs changed with the homebridge plugin.

ryanschmidt commented 4 years ago

It appears to be this same issue https://github.com/KhaosT/homebridge-camera-ffmpeg/issues/332

jmbwell commented 4 years ago

Combining the camera with the motion sensor into a composite device apparently helps, and might actually be an improvement for this plugin.

This would not fix rich notifications with other sensors in the room, but that sounds like a constraint introduced to HomeKit by Apple.

vddgil commented 4 years ago

Audio/video works great in iOS 13. I don’t use notifications, so I’m not sure about them either way.

Here’s a screen shot from the Home app on my phone running the latest beta: F895658E-54BF-4C37-966A-32944CF625A3

Hey @JJJ Hom did you managed to have sound with this plugin, for me it's just disabled ...

Thanks a lot !

Gil

roycepope commented 4 years ago

@vddgil Confirmed no sound at all on iOS 13.1.2

JJJ commented 4 years ago

Here’s a modified version of my config. This likely requires FFMpeg itself to be compiled as per the instructions in the Wiki here in this repository. I went through various different sets of flags, and I’m not 100% confident what they are, but I’ll post them here if I can pull them out of FFMpeg.

        {
            "platform": "Camera-ffmpeg",
            "cameras": [
                {
                    "name": "Whatever",
                    "videoConfig": {
                        "source": "-rtsp_transport tcp -re -i rtsp://your-cloud-key-url",
                        "stillImageSource": "-i http://your-camera-ip/snap.jpeg",
                        "additionalCommandline": "-preset slow -profile:v high -level 4.2 -x264-params intra-refresh=1:bframes=0",
                        "vcodec": "h264_omx",
                        "packetSize": 188,
                        "audio": true,
                        "maxStreams": 2,
                        "maxWidth": 1920,
                        "maxHeight": 1080,
                        "maxFPS": 15,
                        "maxBitrate": 300,
                        "mapaudio": "0:0",
                        "mapvideo": "0:1"
                    }
                },
            }

I’m currently running the 13.2 beta, also with sound. It’s been pretty inconsistent between iOS and iPadOS versions. Sometimes streams would completely fail on my iPhone only and work fine in the Home app on my Mac, etc…

vddgil commented 4 years ago

Hello @JJJ and thanks for your answer. What do you mean by "in the Wiki here in this repository.". I can't find any instructions on how to compile ffmpeg in the wiki ...

Thanks in advance !

Gil

ryanschmidt commented 4 years ago

Still no luck with this. I'm getting snapshots for other plugins like homebridge-ring so I'm wondering if there is something required to get snapshots to work again here for iOS 13. Any pointers would be appreciated!

JJJ commented 4 years ago

@vddgil Sorry; from the Wiki on the original fork this repo was born from:

https://github.com/KhaosT/homebridge-camera-ffmpeg/wiki/Raspberry-PI

I happen to be setting up a new HomeBridge instance from scratch, so I'll be testing this momentarily.

ffmpeg -sample_fmts will output a bunch of helpful stuff, including configuration: which is where you can see what flags its been compiled with.

JJJ commented 4 years ago

@vddgil Sooo.... I followed the instructions in the Wiki link above, and nothing works - not even basic video. It appears I have some more research to do.

ryanschmidt commented 4 years ago

Still stuck on this :(

Is this related? https://github.com/KhaosT/homebridge-camera-ffmpeg/wiki/iOS-13-and-Photo-Notifications?utm_source=share&utm_medium=ios_app&utm_name=iossmf

jnanes commented 4 years ago

any news on this?

ryanschmidt commented 4 years ago

No news. Just sadness and image-less notifications.

jnanes commented 4 years ago

About to give up hope. Still sitting back on ios12

ukypayne commented 4 years ago

I'm on iOS 13 and have the regular camera options working fine.

I didn't know the snapshot & push notification was an option. Is there active development in this UFV branch to possibly get this to work? I tried the flags that @JJJ listed above but had nothing actually appear.

jnanes commented 4 years ago

Billy,

You have the push notification with screenshots working? Can you clarify how as it doesn’t work for others afaik? On Nov 24, 2019, 7:25 PM -0500, Billy notifications@github.com, wrote:

I'm on iOS 13 and have the regular camera options working fine. I didn't know the snapshot & push notification was an option. Is there active development in this UFV branch to possibly get this to work? I tried the flags that @JJJ listed above but had nothing actually appear. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

ukypayne commented 4 years ago

@jnanes No, I do not have screenshots working. I said I had the old functions of just seeing the camera.

jnanes commented 4 years ago

Sorry I was confused, as the old function was to receive notifications... On Nov 26, 2019, 4:04 PM -0500, Billy notifications@github.com, wrote:

@jnanes No, I do not have screenshots working. I said I had the old functions of just seeing the camera. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

cburn commented 4 years ago

Combining the camera with the motion sensor into a composite device apparently helps, and might actually be an improvement for this plugin.

This would not fix rich notifications with other sensors in the room, but that sounds like a constraint introduced to HomeKit by Apple.

Yep, that seems to have fixed it. My PR #43 fixes the rich notifications by adding the motion sensor as a service on the camera.

jnanes commented 4 years ago

@cburn sorry for being naive, is there a way I can apply this patch manually or do I need to wait for it to be merged?

cburn commented 4 years ago

@jnanes you can clone from my fork to get it for now - https://github.com/cburn/homebridge-camera-ffmpeg-ufv

jnanes commented 4 years ago

::googles Clone::

Ok thank you sir! On Dec 7, 2019, 11:54 AM -0500, cburn notifications@github.com, wrote:

@jnanes you can clone from my fork to get it for now - https://github.com/cburn/homebridge-camera-ffmpeg-ufv — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

jnanes commented 4 years ago

@cburn I was able to clone your fork but am not getting the rich notifications on iOS 13. Is there any change needed to my config file or anything else?

cburn commented 4 years ago

@jnanes you'll have to manually install this as well. Might be easier to wait for it to be updated on NPM.

npm -g uninstall homebridge-camera-ffmpeg-ufv
cd <to where you cloned my fork to>
npm i
npm install -g
jmbwell commented 4 years ago

Yeah sit tight cowpokes, got a house full of people and Christmas trees going up. Will try again this evening

jnanes commented 4 years ago

No worries, after I broke my instance by trying to manually install I reverted my snapshot and I'm now waiting patiently.

Thanks for all the hard work!!

jmbwell commented 4 years ago

Okay, I've updated npm with the latest patch. Thanks for all the effort y'all