gp1313 / iep

Automatically exported from code.google.com/p/iep
0 stars 0 forks source link

QtGui.QApplication.setLibraryPaths([]) only if frozen? #138

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
The statement
QtGui.QApplication.setLibraryPaths([])
in __init__.py::246 breaks platform integration (i.e. using KDE, the oxygen 
theme will not be listed as available theme, the open dialog is the default-qt 
one instead of the kde one, etc.)

Since in the code the reasoning is:

#Prevent loading plugins form the users' plugin dir since
#this may cause multiple versions of the Qt library to be loaded
#at once, which will conflict

I guess this is important for cases where the libraries are bundled (i.e. in 
"frozen" distributions of the program). But in cases where the program is 
installed from source, this is not necessary as far as I can tell.

Maybe one could change that line to
if hasattr(sys, 'frozen') and sys.frozen:
    QtGui.QApplication.setLibraryPaths([])
?

Version: iep-3.1

Original issue reported on code.google.com by manisan...@gmail.com on 21 Dec 2012 at 1:23

GoogleCodeExporter commented 8 years ago
I was not aware of this side-affect, thanks!

I am a bit afraid though, that it could still be a problem, for instance in 
case of multiple Python distributions, but I will definitely look into it...

Original comment by almar.klein@gmail.com on 21 Dec 2012 at 1:27

GoogleCodeExporter commented 8 years ago
Wow, thanks for the fast reply!

In the case of multiple python distrubutions, isn't it the responsibility of 
the respective python executable to set the environment correctly? I.e. the 
pythonpath should only include the site-packages for the version matching the 
executable.

Original comment by manisan...@gmail.com on 21 Dec 2012 at 1:36

GoogleCodeExporter commented 8 years ago
I can't remember the exact situation. (I'm not even sure whether it was based 
on an issue from a user, or something we saw ourselves)

But I suspect it was related to Qt libraries, so you're dealing with PATH.

Original comment by almar.klein@gmail.com on 21 Dec 2012 at 3:19

GoogleCodeExporter commented 8 years ago
It'd be really good to see this fixed. As it is now iep looks out of place on 
my KDE system.

Original comment by schivmei...@gmail.com on 12 Feb 2013 at 10:31

GoogleCodeExporter commented 8 years ago
This issue was closed by revision be2508d3322e.

Original comment by almar.klein@gmail.com on 13 Feb 2013 at 10:59

GoogleCodeExporter commented 8 years ago
Note the change to fix issue 198:

https://code.google.com/p/iep/source/detail?r=81204d9753ce58401e34d651789aaf1ad5
495300

Original comment by almar.klein@gmail.com on 11 Mar 2013 at 12:23