gpac / ComplianceWarden

A pluggable compliance checker (ISOBMFF, HEIF/MIAF/AVIF, AV1 HDR10+)
https://gpac.github.io/ComplianceWarden-wasm/
Other
17 stars 7 forks source link

MIAF spec should also test HEIF spec which should test ISO BMFF spec #6

Closed aklemets closed 3 years ago

aklemets commented 4 years ago

It is possible that I read the code incorrectly, but it looks like when testing the MIAF spec, it is only testing the rules that are related to MIAF. So, to fully verify MIAF compliance one would have to run the program three times: Once for MIAF, once for HEIF and once for ISO BMFF.

Maybe this is intentional, but I think it would be more convenient to have the MIAF spec handler also include all the HEIF test cases, and the HEIF test cases should include all the ISO BMFF test cases.

rbouqueau commented 4 years ago

Agreed. My only concern is that MIAF checks are almost complete whereas HEIF and ISOBMF still require a lot of work (looking for contributors or sponsors!).

rbouqueau commented 3 years ago

Fixed by 41b4e1197f81dd2fc449f9f28bbc027a214057bc