search

gpac / ComplianceWarden

A pluggable compliance checker (ISOBMFF, HEIF/MIAF/AVIF, AV1 HDR10+)
https://gpac.github.io/ComplianceWarden-wasm/
Other
17 stars 7 forks source link

successful_checks is always empty for AVIF #83

Open leo-barnes opened 1 month ago

leo-barnes commented 1 month ago

Describe the issue When compiling the latest ComplianceWarden and running it on an AVIF file with JSON output, the "successful_checks" array is always empty.

Detailed analysis From comparing the avif.cpp rules to the av1_hdr10plus.cpp rules, the latter seem to be using out->covered();. I'm assuming this is the snippet that marks the rule as successfully checked.

This would be required in order to implement https://github.com/AOMediaCodec/av1-avif/issues/219

leo-barnes commented 1 month ago

Yup, the out->covered(); calls seem to be the issue.

rbouqueau commented 1 month ago

Indeed. You can add them based on the code (+ the coverage report you can generate with this script).