search

gpac / mp4box.js

JavaScript version of GPAC's MP4Box tool
https://gpac.github.io/mp4box.js/
BSD 3-Clause "New" or "Revised" License
1.94k stars 326 forks source link

ref is not defined (ISOFile.prototype.getInfo) #262

Closed turbobuilt closed 2 years ago

turbobuilt commented 2 years ago

Hi, and thanks for a great library. This makes my job a lot easier! I found a small bug when parsing an MP4 (mov) file from my phone. I get the error ref is not defined when the function ISOFile.prototype.getInfo is running. I found out how to fix it though, just put var in front of the word ref and it works. I have linked to the affected line so that it can be easily found and fixed. Once again thanks for all the hard work. I hope this bug report is correct and that I didn't mess it up somehow.

https://github.com/gpac/mp4box.js/blob/4e1bc23724d2603754971abc00c2bd5aede7be60/src/isofile.js#L337

cconcolato commented 2 years ago

Thanks. This has been fixed in https://github.com/gpac/mp4box.js/pull/276.