gpac / mp4box.js

JavaScript version of GPAC's MP4Box tool
https://gpac.github.io/mp4box.js/
BSD 3-Clause "New" or "Revised" License
1.89k stars 318 forks source link

doc: Fix variable naming inconsistency in MP4Box initialization #386

Closed gspinoza closed 4 months ago

gspinoza commented 4 months ago

Description

updated README.md to fix a variable naming inconsistency mistake in mp4boxfile initialization. The mistake is in the code for the Segmentation example.

should be:

var mp4boxfile = MP4Box.createFile();
mp4boxfile.onReady = function(info) {
  ...
};

not:

var mp4box = MP4Box.createFile();
mp4boxfile.onReady = function(info) {
  ...
};

Changes

Renamed the variable mp4box to mp4boxfile for consistency throughout the codebase.

cconcolato commented 4 months ago

Thank you.