Closed rbouqueau closed 3 months ago
@rbouqueau please check my comments. The PR is also missing the new filter documentation. The new pages must be manually added to the navigation tree : https://github.com/gpac/wiki/blob/master/mkdocs.yml#L70
The PR is also missing the new filter documentation.
Added via updating master
The new pages must be manually added to the navigation tree : https://github.com/gpac/wiki/blob/master/mkdocs.yml#L70
Done
@rbouqueau the new filter dec_scte35
and the output of gpac -genmd
are not automatically added. Such updates need to be pushed explicitly to the wiki. You want to add that filter's page to the navigation tree as well.
@nlsdvl Thanks. I did push it 22b8e11b490289c5ec1b8a9c6a261d1879d9acc2 but in master to avoid polluting this branch. The main PR (https://github.com/gpac/gpac/pull/2748) was merged in between.
Can we merge?
You did not add Filters/scte35dec.md to the index. I'll take care of it.
waiting for https://github.com/gpac/gpac/pull/2748 to be merged