search

gpac / wiki

GPAC's wiki, the entrypoint to MP4Box and GPAC documentation.
https://wiki.gpac.io
GNU Lesser General Public License v2.1
0 stars 3 forks source link

scte35 documentation #4

Closed rbouqueau closed 3 months ago

rbouqueau commented 3 months ago

waiting for https://github.com/gpac/gpac/pull/2748 to be merged

nlsdvl commented 3 months ago

@rbouqueau please check my comments. The PR is also missing the new filter documentation. The new pages must be manually added to the navigation tree : https://github.com/gpac/wiki/blob/master/mkdocs.yml#L70

rbouqueau commented 3 months ago

The PR is also missing the new filter documentation.

Added via updating master

The new pages must be manually added to the navigation tree : https://github.com/gpac/wiki/blob/master/mkdocs.yml#L70

Done

nlsdvl commented 3 months ago

@rbouqueau the new filter dec_scte35 and the output of gpac -genmd are not automatically added. Such updates need to be pushed explicitly to the wiki. You want to add that filter's page to the navigation tree as well.

rbouqueau commented 3 months ago

@nlsdvl Thanks. I did push it 22b8e11b490289c5ec1b8a9c6a261d1879d9acc2 but in master to avoid polluting this branch. The main PR (https://github.com/gpac/gpac/pull/2748) was merged in between.

rbouqueau commented 3 months ago

Can we merge?

nlsdvl commented 3 months ago

You did not add Filters/scte35dec.md to the index. I'll take care of it.