search

gpambrozio / BlockAlertsAnd-ActionSheets

Beautifully done UIAlertView and UIActionSheet replacements inspired by TweetBot
http://codecropper.com/2012/01/replicating-tweetbots-alerts-and-action-sheets/
MIT License
1.41k stars 268 forks source link

Two or more UITextFields #15

Closed lucamarogna closed 11 years ago

lucamarogna commented 12 years ago

how can i insert 2 or more uitextfields in blocktextpromptalertview?!

gpambrozio commented 12 years ago

Another very nice consequence of this library is that is implemented as a simple UIView with labels and buttons. So it's very easy to modify the behavior and add stuff. Check out the source code. And if you manage to do this, please do a pull request so I can add this back to the main repo.

dchohfi commented 12 years ago

I've implemented this, but fixed to 2 UITextFields on screen, more then that could not fit the screen depending on the size of the text. Could be useful? If so I'll send a pull request.

gpambrozio commented 12 years ago

I depends on how you've implemented this. Send the pull request so I can decide. Thanks again.

dchohfi commented 12 years ago

I'm going make some refactories too, adding a class to represent a UITextField configuration, giving the opportunity to extend the UITextField behavior. How about?

gpambrozio commented 12 years ago

Love to see this. Have at it!

dchohfi commented 12 years ago

May I broke back compatibility? The BlockTextPromptAlertView constructors may receive a new parameter: BlockTextPromptAlertView having all the configs to extend the default behavior of a UITextField..

gpambrozio commented 12 years ago

I would not like that. Isn't there another way? Maybe using a property instead of a parameter in the constructor?

barrettj commented 11 years ago

I'm going to close this as it's a year old and I (nor any of the other contributors, to my knowledge) have no plans to add a second text block as of this writing.

The code has been refactored to make these changes much easier if desired (subclass inits and "addComponents" and probably modify the block for shouldDismiss).

If anyone implements this subclass (and preferably adds a sub-podspec for it :P) send a pull request.

ashokvadivelu commented 9 years ago

How can i access this shouldismiss property in my class. What is the use of shoulddismiss?