search

gpanders / nvim-parinfer

parinfer for Neovim
Other
169 stars 4 forks source link

Smart mode behaves like indent mode? #6

Closed knubie closed 2 years ago

knubie commented 2 years ago

Hey there, I'm just checking out the plugin, but I can't seem to get smart mode to work as I expected it to. It seems to operate like indent mode. I've recorded a couple of demos comparing the plugin with the parinfer demo online.

https://user-images.githubusercontent.com/431251/144957899-cac6f05b-4c7a-4f02-b85d-5b91049c62f9.mov

https://user-images.githubusercontent.com/431251/144957946-f4834e74-95bf-4e94-955c-d534a5683762.mov

gpanders commented 2 years ago

This should be resolved when #8 is merged. If you're up for it, please checkout the changes branch locally and let me know if you find any bugs or unexpected behavior.

knubie commented 2 years ago

Thanks for the update @gpanders, but I'm still seeing the same behavior as in the video I posted.

gpanders commented 2 years ago

Are you sure you checked out the changes branch? If I replicate your example it works as expected.

https://user-images.githubusercontent.com/8965202/153268932-da963380-4571-47ee-a5e3-40b955e1899d.mov

knubie commented 2 years ago

I'm pretty sure I was on changes, but I just tried again on master and it seems to work now. I'll switch to using this plugin full time and let you know if I run into any more issues. Thanks!

nstgc commented 2 years ago

I see this issue was resolved by a PR in February and the latest version is from April. Is this expected to work? I installed with vim-plugged, but Smart acts like Indent, and Paren acts like the plug in is disabled.

edit: I'm sorry. I should not post tickets late at night. I had the wrong idea as to how Paren mode works and quickly jumped to conclusions. Ignore this.