search

gpc / fields

a spiritual successor to the bean-fields plugin
http://gpc.github.io/fields/
84 stars 104 forks source link

inList i18n labels are being ignored. #272

Open aadrian opened 6 years ago

aadrian commented 6 years ago

Hi,

It seems that inList elements that have labels in the i18n files are rendered without those labels.

e.g. https://github.com/aadrian/fieldbugs1/blob/master/grails-app/domain/com/mycorp/fieldbugs1/TableOne.groovy#L8 and https://github.com/aadrian/fieldbugs1/blob/master/grails-app/domain/com/mycorp/fieldbugs1/TableOne.groovy#L10

have i18n labels starting from https://github.com/aadrian/fieldbugs1/blob/master/grails-app/i18n/messages.properties#L73

yet in the index, show and edit/create views they don't seem to be used :(. Other labels seem to be used correctly.

Thank you.

zexxar commented 6 years ago

I also noticed this problem.

JacobAae commented 6 years ago

I think this should be an opt-in solution/configurable. There have never been support for this, and we could break behavior if changing it. Imagine a inLIst:['S','M','L','XL'] which renders just the single letter now, upgrading the plugin suddenly would render some.package.name.l.label

aadrian commented 6 years ago

think this should be an opt-in solution/configurable.

As I mentioned in the description: "inList elements that have labels in the i18n files"