search

gpc / jms

JMS integration for Grails.
http://grails.org/plugin/jms
16 stars 28 forks source link

Start listeners manually in bootstrap #8

Closed MayGo closed 6 years ago

graemerocher commented 10 years ago

this pul request is causing the tests to fail on Travis

MayGo commented 10 years ago

Completed 23 integration tests, 0 failed There is " java.lang.RuntimeException: Bang!!!!!" error in master branch.

graemerocher commented 10 years ago

It is not the integration tests that failed it is the unit tests

berngp commented 10 years ago

@MayGo please update to master, added some changes (ce9fed35f227a290d003809dce3268c5a55cd8f9) that will aid you understand where the failures are.

MayGo commented 10 years ago

I made function strongy typed to make it clearer: ServiceInspector.resolveDestinationName(final String name, GrailsApplication grailsApplication) But unit test invokes method with MockApplicationContext.instead of GrailsApplication mock. Should i fix service method (undo) or fix unit test to use GrailsApplication?

svene commented 9 years ago

I would be interested in this functionality as well. Is someone still working on this this PR?

froilan commented 8 years ago

@MayGo Hi, keen to have this functionality. Any reason why this is not yet merged?

jeffscottbrown commented 8 years ago

@froilan This plugin is in need of a shepherd. Are you interested in helping with that?

froilan commented 8 years ago

@jeffbrown Sure, we need it anyways. What needs to be done?

jeffscottbrown commented 8 years ago

@MayGo Made the change. Are you interested in being added as a collaborator and helping to maintain the plugin?

froilan commented 8 years ago

@jeffbrown Alright.