gpc / joda-time

A plugin that Integrates the Joda Time date/time library into Grails
http://gpc.github.com/joda-time
Apache License 2.0
25 stars 38 forks source link

Artifact name convention #24

Open robertoschwald opened 8 years ago

robertoschwald commented 8 years ago

The plugin artifact currently is named "joda-time-.jar".

Normally plugins use the convention

grails-plugin-<name>-<version>.jar
graemerocher commented 8 years ago

That is not the convention in Grails 3 as far as I am aware. Other than for core plugins

robertoschwald commented 8 years ago

I thought so, and I also think its a good idea to distinguish the plugin artifact from dependencies to avoid naming collisions with artifacts.

E.g. the joda-time jar has the same name, so the risk to have a naming clash is eminent:

joda-time-2.0.0.jar
joda-time-2.9.1.jar

Other plugins I use, have the said convention:

grails-plugin-async-3.0.10.jar
grails-plugin-codecs-3.0.10.jar
grails-plugin-controllers-3.0.10.jar
grails-plugin-converters-3.0.10.jar
grails-plugin-databinding-3.0.10.jar
grails-plugin-datasource-3.0.10.jar
grails-plugin-domain-class-3.0.10.jar
grails-plugin-events-3.0.10.jar
grails-plugin-filters-3.0.10.jar
grails-plugin-gsp-3.0.10.jar
grails-plugin-i18n-3.0.10.jar
grails-plugin-interceptors-3.0.10.jar
grails-plugin-mimetypes-3.0.10.jar
grails-plugin-rest-3.0.10.jar
grails-plugin-services-3.0.10.jar
grails-plugin-url-mappings-3.0.10.jar
grails-plugin-validation-3.0.10.jar
graemerocher commented 8 years ago

They can be distinguished by their group id, all plugins are published under the org.grails.plugins group. The plugins you mention there are all core plugins published with grails

robertoschwald commented 8 years ago

Yes, but if you create a war file, an artifact filename can clash with the plugin jar filename, or?