search

gpertea / gclib

GCLib - Genomic C++ library of reusable code for bioinformatics projects
Other
33 stars 13 forks source link

subnamespace for chrono #3

Closed bernt-matthias closed 5 years ago

bernt-matthias commented 5 years ago

During building a new conda package for this library (https://github.com/bioconda/bioconda-recipes/pull/12416) I had the problem that the compiler reported an ambiguous namespace for chrono.

Could you change this to a subnamespace as my patch here:

https://github.com/bioconda/bioconda-recipes/blob/7935ca76ad53a7263d3457afd10d6656b6eb937a/recipes/gclib/chrono.patch

or use the std::chrono and std::ratio namespaces?

bernt-matthias commented 5 years ago

Since this part of the code seems not relevant for gffcompare I also close this issue.

Thanks for your comments and for providing the software.

gpertea commented 5 years ago

Agreed, though the issue is still relevant to me as there are other programs which actually use that code (fqtrim, stringtie) and I am grateful for reporting the issue and for the suggested fix (thank you!).

Could you please let me know what was the compiler & platform where the namespace conflict was encountered? I understand it's now part the recent C++ standard, just wanted to know where that was actually implemented so I can check for it (and possibly other issues) myself (I'm guessing it's the latest MacOS XCode compiler?)

bernt-matthias commented 5 years ago

The problem occurred during building of the conda package. I'm not sure which compile is user there. But the MacOS compiler seems to be a good guess.