gpg-rs / gpgme

GPGme bindings for Rust
GNU Lesser General Public License v2.1
83 stars 13 forks source link

Context::pinentry_mode should take `&self` not `self` #17

Closed ooesili closed 6 years ago

ooesili commented 6 years ago

The current signature of pinentry_mode is this:

fn pinentry_mode(self) -> PinentryMode

I feel like it should be this:

fn pinentry_mode(&self) -> PinentryMode

It seems overkill to have a method that seems to be nothing more than a getter take ownership of self.