search

gphk-metrics / stata-multe

Multiple Treatment Effects
17 stars 4 forks source link

Pull Request for #3: Package Refinement #5

Closed mcaceresb closed 2 years ago

mcaceresb commented 2 years ago

@jerrayc Can you confirm all the TODOs here and here are done, except for the ones in the follow-up here?

I believe you have already done this, so this could PR may just reading through the list to double-check we didn't miss anything (and also running the unit tests after uninstalling and reinstalling into a fresh Stata session; I have done this as well). Once we merge the PR we can tell the team to take the package for a spin (feel free to tag Peter in the follow-up issue #4 to get his feedback on the points you raised here.

jerrayc commented 2 years ago

Have you thought about my question here regarding Wm? Other than this, I successfully ran the unit test on a fresh Stata session (uninstalling and reinstalling multe), and I have confirmed that we have done all the things on the checklists.

Once we squash and merge I will reach out to Peter regarding the questions I raised (again here), and also see if he wants me to go in further detail on the theory in the helpfile. I kept it kind of sparse for now since I don't know how much we want to explain in the helpfile vs. just referring to the paper.

mcaceresb commented 2 years ago

Have you thought about my question here regarding Wm?

Yes. This is point 5 in #4. Postestimation (i.e.predict) would be the standard way to do it. Haven't added the mechanics yet tho.

Other than this, I successfully ran the unit test on a fresh Stata session (uninstalling and reinstalling multe), and I have confirmed that we have done all the things on the checklists.

Once we squash and merge I will reach out to Peter regarding the questions I raised (again here), and also see if he wants me to go in further detail on the theory in the helpfile. I kept it kind of sparse for now since I don't know how much we want to explain in the helpfile vs. just referring to the paper.

Sounds good. Will S&M im a bit.

mcaceresb commented 2 years ago

Summary here.