search

gphk-metrics / stata-multe

Multiple Treatment Effects
17 stars 4 forks source link

Pull Request for #4: Refinement Follow-ups #6

Closed jerrayc closed 2 years ago

jerrayc commented 2 years ago

Did I do this "PR" thing right? If there are any comments to make on the helpfile revisions, or any of the changed code, please let me know!

mcaceresb commented 2 years ago

@jerrayc Made some minor edits to the help file in a94a970ceac53c9796766d5759555f330eb7aaa7.

One thing to note is that per here and here I added a note that the star file is also available online (so it's both included as one of the SSC files and online on GH. Thoughts?

jerrayc commented 2 years ago

@jerrayc Made some minor edits to the help file in a94a970.

One thing to note is that per here and here I added a note that the star file is also available online (so it's both included as one of the SSC files and online on GH. Thoughts?

Thanks for helpfile edits--going through comments now.

Star data explanation: yup, I think including both is good.

mcaceresb commented 2 years ago

@jerrayc I'm good to squash and merge this on my end. After that we can open follow-ups to tackle speed, weights, and package submission. I added a text file with the SSC stuff in df7fcdf09176d511fe424cfdf64cb5b14c5daa99; I figured it was a thing to do so we could ask feedback on the text from the group in the follow-up issue.

mcaceresb commented 2 years ago

Summary here