search

gphocs-dev / G-PhoCS

G-PhoCS is a software package for inferring ancestral population sizes, population divergence times, and migration rates from individual genome sequences.
33 stars 4 forks source link

GPhoCS.h and patch.h #18

Closed gphocs-dev closed 7 years ago

gphocs-dev commented 7 years ago

These new header files seem fine, but global variables should be migrated out of them and into the appropriate C file. The header files should contain only function / variable declarations and type definition. Global variable declaration is done via the extern command.

selotape commented 7 years ago

Evgeny, may I leave this to you (moving the globals into C files)?

gphocs-dev commented 7 years ago

This is fine for now. Seems like the only problem this can cause is prompting an "unused variable" warning if a C file includes the h files but doesn't access one of the variables there. We'll look into this later (not urgent).