search

gphocs-dev / G-PhoCS

G-PhoCS is a software package for inferring ancestral population sizes, population divergence times, and migration rates from individual genome sequences.
33 stars 4 forks source link

Bad usage of processHetPatterns() #28

Closed selotape closed 7 years ago

selotape commented 7 years ago

My IDE noticed a misusage of a function in AlignmentProcessor.cpp -

(https://github.com/gphocs-dev/G-PhoCS/blob/master/src/AlignmentMain.c#L118

Here we give the function processHetPatterns() only one parameter though it requires seven.

I've no idea why this is or whether it causes any real issue.

gphocs-dev commented 7 years ago

Okay. Evgeny looked at this. AlignmentMain.c contains several faulty calls to functions in AlignmentProcessor.cpp. This is probably rooted in "ancient" modifications of the code. For now, we flagged this source file as "buggy" and removed its compilation from the Makefile.

--Ilan

On Sat, May 27, 2017 at 10:27 PM, Ron notifications@github.com wrote:

My IDE noticed a misusage of a function in AlignmentProcessor.cpp -

(https://github.com/gphocs-dev/G-PhoCS/blob/master/src/ AlignmentMain.c#L118 https://github.com/gphocs-dev/G-PhoCS/blob/master/src/AlignmentMain.c#L118

Here we give the function processHetPatterns() only one parameter though it requires seven.

I've no idea why this is or whether it causes any real issue.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gphocs-dev/G-PhoCS/issues/28, or mute the thread https://github.com/notifications/unsubscribe-auth/AN30LjYgURVTrA1xuxsDHQJOLz7iubmhks5r-Hk-gaJpZM4Nockr .

evgenyidc commented 7 years ago

Fix of Makefile will be provided with the next commit.