gphoto / gphoto2

The gphoto2 commandline tool for accessing and controlling digital cameras.
GNU General Public License v2.0
707 stars 116 forks source link

tests/testsuite test037 requires that gphoto2 is built with libexif support #421

Open ndim opened 3 years ago

ndim commented 3 years ago

Describe the bug

As described in https://github.com/gphoto/gphoto2/issues/420, the gphoto2 tests/testsuite bash script runs its test037 unconditionally, which means that the test suite requires that gphoto2 is built with libexif support.

However, the buildsystem and the gphoto2 source code still support building gphoto2 without libexif support.

libgphoto2 and gphoto2 version

[user@host gphoto2]$ ./_build/master/gphoto2/gphoto2 --version | tail -n3
gphoto2         2.5.27.1       gcc, popt(m), no exif, cdk, aa, jpeg, readline
libgphoto2      2.5.27         standard camlibs, gcc, ltdl, EXIF
libgphoto2_port 0.12.0         iolibs: disk ptpip serial usb1 usbdiskdirect usbscsi, gcc, ltdl, EXIF, USB, serial lockdev locking
[user@host gphoto2]$ git rev-parse HEAD
96dbd34de5393f6da6d402836af4aec1a7d9c573
[user@host gphoto2]$ 

To Reproduce Steps to reproduce the behavior:

Possible resolutions

Either

I do not want to make that decision on my own.

ndim commented 3 years ago

OK, regarding easier to implement... well... teaching tests/testsuite to skip some tests if necessary is not that difficult.

Possible parts of an implementation:

If we anticipate other test cases which could make use of that kind of mechanism, I would implement it.

On the other hand, the goal of reducing build complexity would be best served by always requiring libexif.