Restrict matplotlib connextions to 1 or 2D. Fixes #15

gpilab / core-nodes

The core nodes are a collection of basic data manipulation and visualization algorithms.

http://docs.gpilab.com/en/develop/NodeDev/devguide.html

BSD 3-Clause "New" or "Revised" License

11 stars 6 forks source link

Restrict matplotlib connextions to 1 or 2D. Fixes #15 #16

Closed borupdaniel closed 5 years ago

borupdaniel commented 5 years ago

This is a pretty trivial bug fix but I want to go ahead and publish it as it's a crashing bug.

borupdaniel commented 5 years ago

@aganders3 I think this repo is set up so that a code owner other than the Pull Request submitter has to review & approve. Since it's just the two of us, I could take that off depending on how quick you think you'll be able to look at PRs. I think it'd be good practice for big changes but maybe not necessary for minor bugfixes like this.

borupdaniel commented 5 years ago

Me too. I wonder if it threw a "nicer" error in earlier versions of Matplotlib, or maybe the qtwidgets upgrade changed how the error was handled.