search

gpilab / core-nodes

The core nodes are a collection of basic data manipulation and visualization algorithms.
http://docs.gpilab.com/en/develop/NodeDev/devguide.html
BSD 3-Clause "New" or "Revised" License
12 stars 6 forks source link

Dimensions node undesirable behaviors #26

Open borupdaniel opened 4 years ago

borupdaniel commented 4 years ago

The dimensions node has numerous bugs and undesirable behavior.

The only repeatable issue I have is with the split functionality - given a new input, split will revert to N and 1. I think this has to do with how the validate function runs and adjusts the values to fit with the input data, but it is problematic when saving networks with Dimensions nodes, or when loading new data from a file in the same network.

(porting from @nckz on GitLab a while back)

rkrobison commented 4 years ago

It would take a substantial rewrite of the validate function to fix this issue. I have created a new Reshape node , which should hopefully address these issues.

borupdaniel commented 4 years ago

Cool, thanks Ryan! I'll give that a try. Appreciate the contribution!