Error in `dplyr::na_if()`:

[RobiinRoad]

Hello, thank you for thiz amazing tool. Unfortunately, when i launch the "swim_parse" function, I have this error 👍 Error in dplyr::na_if(): ! Can't convert y to match type of x . It is also reported here : https://cran.irsn.fr/web/checks/check_results_SwimmeR.html

It seems to be the same for the new version.

Do you have some explanations for that or some solutions to fix it ?

Thank you very much.

Best regards

[gpilgrim2670]

Hi Robiin,

I'm aware of the issue and working (slowly) on a fix. If you're feeling up to it you're welcome to submit a pull request with fixes.

Thanks, Greg

On Wed, Feb 22, 2023 at 10:44 AM RobiinRoad @.***> wrote:

Hello, thank you for thiz amazing tool. Unfortunately, when i launch the "swim_parse" function, I have this error 👍 Error in dplyr::na_if(): ! Can't convert y to match type of x . It is also reported here : https://cran.irsn.fr/web/checks/check_results_SwimmeR.html

It seems to be the same for the new version.

Do you have some explanations for that or some solutions to fix it ?

Thank you very much.

Best regards

— Reply to this email directly, view it on GitHub https://github.com/gpilgrim2670/SwimmeR/issues/6, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK7MTYXAFBUGB6RDIFICWKTWYYX7RANCNFSM6AAAAAAVEP5TAM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[RobiinRoad]

Hello,

Thank you very much for your response.

What I am supposed to do in the pull request please ? (Sorry I am kind of new on GitHub).

Best regards

Le jeu. 23 févr. 2023 à 22:35, Greg Pilgrim @.***> a écrit :

Hi Robiin,

I'm aware of the issue and working (slowly) on a fix. If you're feeling up to it you're welcome to submit a pull request with fixes.

Thanks, Greg

On Wed, Feb 22, 2023 at 10:44 AM RobiinRoad @.***> wrote:

Hello, thank you for thiz amazing tool. Unfortunately, when i launch the "swim_parse" function, I have this error 👍 Error in dplyr::na_if(): ! Can't convert y to match type of x . It is also reported here : https://cran.irsn.fr/web/checks/check_results_SwimmeR.html

It seems to be the same for the new version.

Do you have some explanations for that or some solutions to fix it ?

Thank you very much.

Best regards

— Reply to this email directly, view it on GitHub https://github.com/gpilgrim2670/SwimmeR/issues/6, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AK7MTYXAFBUGB6RDIFICWKTWYYX7RANCNFSM6AAAAAAVEP5TAM

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/gpilgrim2670/SwimmeR/issues/6#issuecomment-1442461799, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARHJFMHDFQYBJL6BOFIPDKLWY7JZFANCNFSM6AAAAAAVEP5TAM . You are receiving this because you authored the thread.Message ID: @.***>

--

Robin PLA Conseiller Technique National FFN PhD en Sciences du Sport Tél : 06.40.53.26.08 Email : *robin @.>.@. @.**>

[gpilgrim2670]

The issue is that I had used the dplyr function na_if in an off-label way. I used it to convert all NA values across a dataframe to particular strings, similar to the pandas replace method. Changes in dplyr make na_if no longer work in that fashion.

Hadley discusses the issue and partially implements fixes here.

Some fixes for dev dplyr by hadley · Pull Request #5 · gpilgrim2670/SwimmeR · GitHub https://github.com/gpilgrim2670/SwimmeR/pull/5

If you'd like, and you're feeling up to it, you can finish implementing fixes such that the package tests all pass and then submit a pull request containing your fixes. I'd of course add you to the authors of the package. Be aware that being an author comes with no glory and also nothing else. As things stand I'll do it when I get some free time - hopefully in the next few weeks.

Greg

On Thu, Feb 23, 2023 at 4:41 PM RobiinRoad @.***> wrote:

Hello,

Thank you very much for your response.

What I am supposed to do in the pull request please ? (Sorry I am kind of new on GitHub).

Best regards

Le jeu. 23 févr. 2023 à 22:35, Greg Pilgrim @.***> a écrit :

Hi Robiin,

I'm aware of the issue and working (slowly) on a fix. If you're feeling up to it you're welcome to submit a pull request with fixes.

Thanks, Greg

On Wed, Feb 22, 2023 at 10:44 AM RobiinRoad @.***> wrote:

Hello, thank you for thiz amazing tool. Unfortunately, when i launch the "swim_parse" function, I have this error 👍 Error in dplyr::na_if(): ! Can't convert y to match type of x . It is also reported here : https://cran.irsn.fr/web/checks/check_results_SwimmeR.html

It seems to be the same for the new version.

Do you have some explanations for that or some solutions to fix it ?

Thank you very much.

Best regards

— Reply to this email directly, view it on GitHub https://github.com/gpilgrim2670/SwimmeR/issues/6, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AK7MTYXAFBUGB6RDIFICWKTWYYX7RANCNFSM6AAAAAAVEP5TAM

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub < https://github.com/gpilgrim2670/SwimmeR/issues/6#issuecomment-1442461799>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ARHJFMHDFQYBJL6BOFIPDKLWY7JZFANCNFSM6AAAAAAVEP5TAM

. You are receiving this because you authored the thread.Message ID: @.***>

--

Robin PLA Conseiller Technique National FFN PhD en Sciences du Sport Tél : 06.40.53.26.08 Email : *robin @.>.@. @.**>

— Reply to this email directly, view it on GitHub https://github.com/gpilgrim2670/SwimmeR/issues/6#issuecomment-1442467284, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK7MTYXGBKDYQM6KQBRBXA3WY7KPHANCNFSM6AAAAAAVEP5TAM . You are receiving this because you commented.Message ID: @.***>