search

gpodder / gpodder-sailfish

gPodder 4 for Sailfish OS Packaging
https://openrepos.net/content/keeperofthekeys/gpodder
49 stars 29 forks source link

Duration menu #109

Closed Keeper-of-the-Keys closed 4 years ago

Keeper-of-the-Keys commented 4 years ago

This adds duration information to 2 possible locations in the Episode list:

Personally I think the subtitle option is better but I figured I would present both and get your opinions before remove one or the other...

Please note you need to add total_time in main.py of gpodder-ui-qml (https://github.com/gpodder/gpodder-ui-qml/pull/11)

Please also note I'm leaving both PRs (gpodder-core and gpodder-ui-qml) open for now and will roll 4.9 version number bumps into them before merging. @carmenfdezb @sfbg

carmenfdezb commented 4 years ago

Hi @Keeper-of-the-Keys! I'm absolutely agree with you, I prefer duration in subtitle instead of episode menu

carmenfdezb commented 4 years ago

Hi @Keeper-of-the-Keys! I would like to add a little fix in gpodder before you release v4.9, is that possible?

carmenfdezb commented 4 years ago

When episode is paused, cover app doesn't show info about episode (podcast and episode title, duration...). I think it is useful to see that info in cover, if an episode is loaded in player. What do you think?

Keeper-of-the-Keys commented 4 years ago

@carmenfdezb Makes sense, is that a small change? I'd like to publish today...

Keeper-of-the-Keys commented 4 years ago

BTW I think for one of the future releases we need to look at a better way to do the qstrings for the translation file, I see in my diff that all kinds of strings are being deleted by qmake updating stuff (which is why I did not commit the updated translation files)

carmenfdezb commented 4 years ago

@carmenfdezb Makes sense, is that a small change? I'd like to publish today...

Yes, it is a small change, I can do it when I come back home within 2 or 3 hours.

carmenfdezb commented 4 years ago

BTW I think for one of the future releases we need to look at a better way to do the qstrings for the translation file, I see in my diff that all kinds of strings are being deleted by qmake updating stuff (which is why I did not commit the updated translation files)

I agree, I will take a look if you want, to solve it in the next release.

Keeper-of-the-Keys commented 4 years ago

OK, I'll merge this but wait for your PR with making a release

carmenfdezb commented 4 years ago

Done! Thank you!

110

carmenfdezb commented 4 years ago

BTW I think for one of the future releases we need to look at a better way to do the qstrings for the translation file, I see in my diff that all kinds of strings are being deleted by qmake updating stuff (which is why I did not commit the updated translation files)

Sorry, are you talking about changes in numbers line in the translation files?

Keeper-of-the-Keys commented 4 years ago

Sorry, are you talking about changes in numbers line in the translation files?

From looking at one of the diffs it seemed that actual text was being lost... (ie being changed to unfinished and set to empty)

I'll try to look at it before I release maybe I just saw wrong.