gpodder / gpodder-sailfish

gPodder 4 for Sailfish OS Packaging
https://openrepos.net/content/keeperofthekeys/gpodder
49 stars 29 forks source link

Graphic glitch with Podcastlogo before episode title #125

Closed peperjohnny closed 3 years ago

peperjohnny commented 4 years ago

There's a minor glitch with the new feature of showing the Podcastlogo before the episode. Normally it should show only once, but it shows next to the length and subinfo of the episode too. Here's a pic of how it looks. Here's how it looks on the filtered view. As far as I can tell it happens only on new downloaded episodes. And on Podcasts where I newly downloaded an episode. This issue persists through a restart of the app. Funnily enough it does not happen to every Podcast or episode, so far for 2 of newly downloaded I had the glitch and for one not. If you need any logs, please tell which and I will provide them gladly.

Keeper-of-the-Keys commented 4 years ago

This is due to the podcast stream using the podcast cover as episode art, basically I download both cover_art and episode_art if both exist you have the 2 pictures if only one exists it shows just 1 picture.

I don't have a trustworthy mechanism to check if both are the same (sometimes it's the same file but sometimes it's not), I guess I could add at least a "same filename" rule to prevent this in that case (I could also compare/hash the files but that would undoubtedly tank performance).

Keeper-of-the-Keys commented 4 years ago

(Do you use nextcloud as e-mail frontend? I'm thinking about using it)

peperjohnny commented 4 years ago

I guess I could live with that, because it's really not a big bother. (Nope. Using it for a variety of different things, but since I have mail clients on every device, I haven't seen any advantage in having it in there too.)

Keeper-of-the-Keys commented 3 years ago

This was resolved I think by the removal of episode art from episode lists (for performance/memory reasons).