search

gpodder / gpodder-sailfish

gPodder 4 for Sailfish OS Packaging
https://openrepos.net/content/keeperofthekeys/gpodder
49 stars 29 forks source link

UI improvments for episodelist #137

Closed thigg closed 4 years ago

thigg commented 4 years ago

Things done:

If accepted, the folder of the former submodule should be renamed probably.

also fixes #37

I tried to capture it a bit:

output

Keeper-of-the-Keys commented 4 years ago

Hey Thilo! Thank you so much for all your effort. I will make an effort to review your different PRs over the next few days (I'll try 1 every day) and then make a release. If you can reopened your PRs that are rolled into this one that is actually better so that each PR only does a small amount of changes. Sorry about all my delays, I had a very busy semester and a new full time job. Thanks again! --Keeper of the Keys

thigg commented 4 years ago

Hi Keeper, thanks for taking your time to review. There are no PRs that rolled into this one, but all the others are based on this one. If I find time today besides work, I might factor out the removal of the gpodder-ui-qml submodule into a seperate PR.

I didnt refactor the submodule to a better name yet etc, because i have some general changes in mind with reorganizing the folder structure etc to make everything a bit more scoped

thigg commented 4 years ago

There is a bug with refreshing from episodelist which causes changes not to be displayed immediatley.

Its a bit hard to test, because you need new episodes in your feed... maybe something could be done with creating a local feed.

A fix would be to just listen on py.refreshing and update the whole list when its done. Partitial updates would require some more work. (like episodes showing up on the fly, not only after whole refresh)

thigg commented 4 years ago

Oh and in this PR main.py was still in .gitignore, thus its missing. the performance PR contains a modified version of it.

Keeper-of-the-Keys commented 4 years ago

Removing gpodder-ui-qml needs to be a separate affair also some of the other translation files seem to have been damaged by the IDE. I'll try to do the removal of gpodder-ui-qml based on your work and then can you rebase your work on the master?

sfbg commented 4 years ago

Persisting the Filter is absolutely great, and has been needed for a long time.

I am nit sure about the Refresh menu entry in the Episodes list, specifically the filtered. For an Episode list of a single Podcast it makes sens for sure. But what use do I have of it in the Downloaded filter for example? Actually it only makes sense in the Fresh list.

carmenfdezb commented 4 years ago

I'm very sorry for the late answer. I fully agree with @sfbg, persisting used filter is really great :-O

thigg commented 4 years ago

closing in favor of the new PRs