search

gpodder / gpodder-sailfish

gPodder 4 for Sailfish OS Packaging
https://openrepos.net/content/keeperofthekeys/gpodder
49 stars 29 forks source link

[on hold] implemented a textsearchfilter for the episodelist #138

Closed thigg closed 3 years ago

thigg commented 3 years ago

fixes #42 is based on #137, thus the diff might be confusing. Can't select the PR as base. Its all in 2b7f595

In Action:

Peek 2020-09-20 00-53

sfbg commented 3 years ago

@thigg @Keeper-of-the-Keys tbh, I do not know if this feature is that useful. Especially as a dedicated filter. Perhaps search right in the episodes list, instead?

As I have mentioned elsewhere, filtering by pulling, then selecting is very cumbersome in my opinion.

thigg commented 3 years ago

Im not using the search very often. Because of that a permanent searchbar seems a bit like a waste of screenspace to me.

Having all the filters directly in the pulley do make the pulley very long (which might not be a problem, would have to try). Also the "refresh podcasts"-item would be strange mixed up with the filters.

My personal workflow with the app is usually having the filtered episodelist open and refreshing the list about twice a day, thus having the refresh action easily accessible from the episodelist seems very practical to me.

Maybe we could put a toolbar on top/bottom which allows search/filter/updating in one element? Maybe it could just be there where the current filter is now shown?

thigg commented 3 years ago

postponed until the other PRs are merged, leaving it open for now for reference. This needs to be rebased on the current master

Keeper-of-the-Keys commented 3 years ago

@thigg @Keeper-of-the-Keys tbh, I do not know if this feature is that useful. Especially as a dedicated filter. Perhaps search right in the episodes list, instead?

As I have mentioned elsewhere, filtering by pulling, then selecting is very cumbersome in my opinion.

Text search would be cool, the exact UX we'll probably need to figure out and polish.

@thigg I'm closing this PR since it is too extensive to review in decent time, feel free to submit a cleaner PR that does only one feature.