search

gpodder / gpodder-sailfish

gPodder 4 for Sailfish OS Packaging
https://openrepos.net/content/keeperofthekeys/gpodder
49 stars 29 forks source link

Remove ui qml #142

Closed Keeper-of-the-Keys closed 3 years ago

Keeper-of-the-Keys commented 3 years ago

Removes gpodder-ui-qml dependency

@thigg @sfbg @carmenfdezb as far as I can tell I did not break anything but I would like to hear other OKs before I merge.

@thigg once this is merged it would be great if you can rebase your PRs on this.

carmenfdezb commented 3 years ago

Hi @Keeper-of-the-Keys! You have a pull request about fixed strings translation from old gpodder-ui-qml. I think the rest of the code is ok

Keeper-of-the-Keys commented 3 years ago

@carmenfdezb are you sure? The PR queue of gpodder-ui-qml is empty and there is no PR by you that was recently merged. https://github.com/gpodder/gpodder-ui-qml/pulls?q=is%3Apr+is%3Aclosed

Keeper-of-the-Keys commented 3 years ago

Housekeeping - This PR closes #93

carmenfdezb commented 3 years ago

@carmenfdezb are you sure? The PR queue of gpodder-ui-qml is empty and there is no PR by you that was recently merged. https://github.com/gpodder/gpodder-ui-qml/pulls?q=is%3Apr+is%3Aclosed

It is in your repo: Keeper-of-the-Keys:remove-ui-qml

thigg commented 3 years ago

What do you think about removing the GPodder prefix from the files? Also the GPodderCore could be renamed to something like GPodderPyConnector. Core seems a bit odd to me here.

thigg commented 3 years ago

Also while at it, maybe it would be good to regroup the files.

Something like (just a quick sketch):

Keeper-of-the-Keys commented 3 years ago

What do you think about removing the GPodder prefix from the files?

I don't see how that provides added value, we are still part of the gPodder project and these files map 1:1 to the reference implementation.

Also the GPodderCore could be renamed to something like GPodderPyConnector. Core seems a bit odd to me here.

I guess that goes back to the fact that most of the python code lives in gpodder-core not sure how much it adds again.

Keeper-of-the-Keys commented 3 years ago

Also while at it, maybe it would be good to regroup the files.

Something like (just a quick sketch):

* model

  * EpisodeListModel, PodcastListModel, [Connections]

* view

  * AboutPage,SettingsPage,...
  * episodelist

    * EpisodeDetail(Page?), AllEpisodesPage, ...
  * player
  * podcasts

* core

  * GpodderCore

Maybe for future but not in this PR, that is feature creep on PRs which makes them a mess and harder to review.

Keeper-of-the-Keys commented 3 years ago

@carmenfdezb @thigg @sfbg if non of you found issues with this PR I will merge it tomorrow.