scheduled update feature [WIP] [request feedback]

thigg commented 3 years ago

Added a systemd timer which can be used to automatically refresh the podcasts. The timer can be configured to a specific time of the day.

[ ] verify refresh is working properly
[ ] add option to disable timer
[ ] make label above button in settings display a nicer representation of the set time
[ ] check if harbour actually allows timers
[ ] find a way to refresh the gui once its done. (dbus?)
[ ] bring python tests into the toolchain
[ ] make sure there are no conflicts if manual sync is triggered during scheduled and vice versa

fixes #156

thigg commented 3 years ago

@sfbg @Keeper-of-the-Keys what do you think?

Keeper-of-the-Keys commented 3 years ago

Looks interesting (just went over code for now), several notes:

Though personally I have unlimited data so I don't care what connection I am on other users don't so ideally an automated service would have some way to limit connection type (this technique could also potentially resolve #10 but not in the same PR please).
I noticed several hardcoded paths these should be avoided if at all possible, depending on how old a Jolla phone install is it will either be running as nemo or as defaultuser.
Knowing whether harbour allows is important because otherwise this will need to be included in the harbour compatibility patch.
There probably also needs to be a notification of some sorts, personally I like to check how many fresh episodes I have before triggering a refresh so that I know whether this number got changed by the refresh and whether or not to look for new episodes.

(As for point 1 I realize that there is a setting to turn this on and off)

thigg commented 3 years ago

Hi,

but I think it is a good idea to either add a hint that scheduled updates will ignore the setting from #155, or we need to make the setting available to the service.
a I forgot about that homepath... its relative now.
How do we find it out?
added the notification. That meant, that the pythonscript needs access to a translation mechanism, thats why we have a very ugly gettext stunt now in there. I wasnt able to find a better solution yet.

thigg commented 3 years ago

systemd-timers are not allowed yet in jollas store, but they are discussed e.g. here and here

gpodder / gpodder-sailfish