search

gpodder / gpodder-sailfish

gPodder 4 for Sailfish OS Packaging
https://openrepos.net/content/keeperofthekeys/gpodder
49 stars 29 forks source link

Update to Amber mpris #172

Closed carmenfdezb closed 1 year ago

carmenfdezb commented 1 year ago

It uses the new mpris module, and cover art is shown now in lockscreen: Captura_20230305_001

Keeper-of-the-Keys commented 1 year ago

Looks very good, this will break support for older phones no? Maybe we can/should add an if(OS<4.5) around the import and keep both?

carmenfdezb commented 1 year ago

I think Amber.Mpris is available since sfos 4.4, but I'm not sure. On the other hand, org.nemomobile.mpris isn't available in a clean install of sfos 4.5

Keeper-of-the-Keys commented 1 year ago

I'm going to find my JP1 and test it on there, I suspect a tiny if/else around the import will be needed.

Keeper-of-the-Keys commented 1 year ago

I found my JP1, it was unable to install the rpm built with the new SDK, I suspect that previous released RPMs have also been uninstallable due to the same issue and nobody yelled so I'm merging this and will make a note in the release notes, if someone wants to build a package for older systems or tell me how I'm more than happy to still try and maintain support but for now this merges and breaks whatever it breaks.