search

gpodder / gpodder

The gPodder podcast client.
http://gpodder.org/
GNU General Public License v3.0
1.28k stars 204 forks source link

iframe in content:encoded <!CDATA[...]> XHTML (in podcasts that have this) causes invokation of default web browser #1612

Open janicez opened 6 months ago

janicez commented 6 months ago

When I click an episode to view its description, I do not expect my default web browser to be launched, containing checks notes an iframe from the content:encoded <!CDATA[...]> XHTML data??? Is this intended behavior? Should I create an RSS feed that forms a minimal reproducer, to show y'all what I mean?

auouymous commented 6 months ago

Is this intended behavior?

Clicking the title in shownotes should open a web browser. Some episodes do not have downloadable content, and playing them will open a web browser because the content is only playable from the website. It shouldn't open a browser if you are simply clicking an episode.

Should I create an RSS feed that forms a minimal reproducer

Yes, please.

janicez commented 6 months ago

https://umbrellix.net/~ellenor/gpodder.rss - although I believe this requires the details pane to be open («Détails de l'épisode» or "Episode details" in the right click menu)

auouymous commented 6 months ago

Are you using Linux with webkit-gtk to get HTML shownotes? If so, does unchecking ui.gtk.html_shownotes in Edit config of Preferences fix the issue?

janicez commented 6 months ago

I unchecked that, and I still have the issue.

However, I don't know if I'm even using webkitgtk, because while it's installed here, I don't think python bindings are.

auouymous commented 6 months ago

DId you restart gpodder after unchecking it? Do you see images in shownotes for some podcasts?

janicez commented 6 months ago

I'd proffer that maybe it should be mentioned in the relevant interface that changing advanced preferences requires a restart.

I'll go and restart it and try now. I have to stir my bread batter anyway.

Update: it appears to not behave this way with HTML shownotes disabled.

auouymous commented 6 months ago

Not all advanced preferences require a restart, and it might be mentioned somewhere that some do, in the fine print. ;)

I am not able to install webkit-gtk to test this, but hopefully there is something gpodder can enable to stop webkit-gtk from automatically opening the browser. A quick search didn't show anything useful.