search

gposton / vagrant-hiera

MIT License
21 stars 12 forks source link

Fix check for apt repo set #5

Closed fgrehm closed 12 years ago

fgrehm commented 12 years ago

The code to check if the puppet apt repo was set was looking at the wrong file (/etc/apt/sources.list) and was adding the repo multiple times

gposton commented 12 years ago

Hey fgrehm, I truly appreciate your work here, but I decided to take the apt_repo_set code out altogether. I know that you wrote this in such a way to not remove functionlity, but the only reason I added this code at all is because I wanted to work towards compatiabiltiy with puppet 3.0 and now that 3.0 is released, I'm not going to support using development versions of puppet. Generally, I avoid removing features/functionality, but I think the code is a bit cleaner without support for pulling development versions and I'm not sure that that functionality really adds alot of value now anyway.